Fix capitalizing words that start with numbers #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix issue where words like "1st" and "2nd" were capitalized as "1St" and "2Nd"
blakeembrey
reviewed
Sep 13, 2024
packages/title-case/src/index.ts
Outdated
| @@ -4,6 +4,7 @@ const IS_MANUAL_CASE = /\p{Ll}(?=[\p{Lu}])/u; // iPhone, iOS, etc. | |||
| const ALPHANUMERIC_PATTERN = /\p{Alphabetic}+/gu; | |||
| const IS_ACRONYM = | |||
| /^(\P{Alphabetic})*(?:\p{Alphabetic}\.){2,}(\P{Alphabetic})*$/u; | |||
| const IS_DIGIT = /\d/u; | |||
There was a problem hiding this comment.
Can you change alphanumeric pattern instead? I think the bug is that it should consider numbers words too.
There was a problem hiding this comment.
@blakeembrey I've update the pattern and removed the check for a numeric digit I had added previously.
Thanks for taking the time to review this PR.
blakeembrey
approved these changes
Sep 13, 2024
| @@ -1,7 +1,7 @@ | |||
| const TOKENS = /(\S+)|(.)/g; | |||
| const IS_SPECIAL_CASE = /[\.#]\p{Alphabetic}/u; // #tag, example.com, etc. | |||
| const IS_MANUAL_CASE = /\p{Ll}(?=[\p{Lu}])/u; // iPhone, iOS, etc. | |||
| const ALPHANUMERIC_PATTERN = /\p{Alphabetic}+/gu; | |||
| const ALPHANUMERIC_PATTERN = /[\p{Alphabetic}\p{Nd}]+/gu; | |||
There was a problem hiding this comment.
Any concerns with just doing \p{N}?
There was a problem hiding this comment.
No concerns with changing to \p{N}
There was a problem hiding this comment.
Release yesterday, cheers! https://github.com/blakeembrey/change-case/releases/tag/title-case%404.3.2
|
Thanks for the catch, embarrassed I didn't have a test for this 😅 |
renovate bot
referenced
this pull request
in JoshuaKGoldberg/emoji-platform-data
Sep 18, 2024
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [title-case](https://github.com/blakeembrey/change-case/tree/master/packages/title-case#readme) ([source](https://github.com/blakeembrey/change-case)) | [`4.3.1` -> `4.3.2`](https://renovatebot.com/diffs/npm/title-case/4.3.1/4.3.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>blakeembrey/change-case (title-case)</summary> ### [`v4.3.2`](https://github.com/blakeembrey/change-case/releases/tag/title-case%404.3.2) [Compare Source](https://github.com/blakeembrey/change-case/compare/[email protected]) **Fixed** - Fix capitalization of words that start with a number [https://github.com/blakeembrey/change-case/pull/346](https://github.com/blakeembrey/change-case/pull/346) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/JoshuaKGoldberg/emoji-platform-data). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC44MC4wIiwidXBkYXRlZEluVmVyIjoiMzguODAuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiZGVwZW5kZW5jaWVzIl19--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue where words that start with numbers have the first non-numeric character capitalized incorrectly. Previously "1st" was being capitalized as "1St".