Fix openssl_dev_headers dep check to require the header - #3282
Merged
Conversation
liquidsec
marked this pull request as draft
July 9, 2026 14:49
Contributor
📊 Performance Benchmark Report
📈 Detailed Results (All Benchmarks)
🎯 Performance Summary! 1 regression ⚠️
30 unchanged ✅🔍 Significant Changes (>10%)
🐍 Python Version 3.11.15 |
_core_dep_satisfied treated the openssl binary as evidence that the dev headers were installed. Minimal images (e.g. python:3.11-slim) ship openssl but not libssl-dev, so the check returned True and the core-deps installer skipped installing the headers, breaking source builds like medusa that need openssl/ssl.h. Closes #3272.
liquidsec
force-pushed
the
medusa-libssl-dep
branch
from
July 9, 2026 15:17
ba0cbf7 to
0a83067
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #3282 +/- ##
=====================================
+ Coverage 90% 90% +1%
=====================================
Files 450 450
Lines 46100 46155 +55
=====================================
+ Hits 41357 41409 +52
- Misses 4743 4746 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
liquidsec
marked this pull request as ready for review
July 9, 2026 17:57
en0f
approved these changes
Jul 9, 2026
This was referenced Jul 9, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3272.
_core_dep_satisfiedtreated theopensslbinary as evidence that theOpenSSL dev headers were installed:
Minimal images (e.g.
python:3.11-slim) ship theopensslbinary butnot
libssl-dev, so the check returned True, the core-deps installerskipped installing the headers, and source builds that compile against
libssl (medusa's
./configure) failed with:Fix: require the actual header.
libssl-dev/openssl-devel/ etc.are already in
CORE_DEPS["openssl_dev_headers"]for every distro, soonce the check reports "not satisfied" they get installed as intended
and medusa (and any other source-built dep) compiles cleanly.
Reproduced on
python:3.11-slim: with the fix,openssl_dev_headerscorrectly reports unsatisfied and
libssl-devgets installed.