Fix stale baddns config key in kitchen-sink preset - #3280
Merged
Conversation
Remove the redundant baddns.enable_references override. baddns-heavy (already included) sets enabled_submodules with references. Add test_bundled_presets_validate_clean to fail CI on any preset that doesn't validate.
Contributor
📊 Performance Benchmark Report
📈 Detailed Results (All Benchmarks)
🎯 Performance Summary+ 1 improvement 🚀
30 unchanged ✅🔍 Significant Changes (>10%)
🐍 Python Version 3.11.15 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #3280 +/- ##
=====================================
+ Coverage 90% 90% +1%
=====================================
Files 450 450
Lines 46100 46111 +11
=====================================
+ Hits 41357 41367 +10
- Misses 4743 4744 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
en0f
approved these changes
Jul 9, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3279.
kitchen-sink.ymlsetmodules.baddns.enable_references: True, whichis no longer a valid config option (the current key is
enabled_submodules). Preset validation fails before the scan starts.The override is also redundant:
kitchen-sinkalready includesbaddns-heavy, which setsenabled_submodules: [CNAME, NS, MX, TXT, references, DMARC, SPF, MTA-STS, WILDCARD].So the fix is to drop the block entirely.
Also adds
test_bundled_presets_validate_clean, which runsvalidate_preset_fileagainst every YAML underbbot/presets/andfails on any error. Would have caught this drift when the baddns option
was renamed.