Skip to content

Fix stale baddns config key in kitchen-sink preset - #3280

Merged
liquidsec merged 1 commit into
devfrom
kitchen-sink-baddns-key
Jul 9, 2026
Merged

Fix stale baddns config key in kitchen-sink preset#3280
liquidsec merged 1 commit into
devfrom
kitchen-sink-baddns-key

Conversation

@liquidsec

Copy link
Copy Markdown
Collaborator

Closes #3279.

kitchen-sink.yml set modules.baddns.enable_references: True, which
is no longer a valid config option (the current key is
enabled_submodules). Preset validation fails before the scan starts.

The override is also redundant: kitchen-sink already includes
baddns-heavy, which sets
enabled_submodules: [CNAME, NS, MX, TXT, references, DMARC, SPF, MTA-STS, WILDCARD].
So the fix is to drop the block entirely.

Also adds test_bundled_presets_validate_clean, which runs
validate_preset_file against every YAML under bbot/presets/ and
fails on any error. Would have caught this drift when the baddns option
was renamed.

Remove the redundant baddns.enable_references override. baddns-heavy
(already included) sets enabled_submodules with references. Add
test_bundled_presets_validate_clean to fail CI on any preset that
doesn't validate.
@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

📊 Performance Benchmark Report

Comparing dev (baseline) vs kitchen-sink-baddns-key (current)

📈 Detailed Results (All Benchmarks)

📋 Complete results for all benchmarks - includes both significant and insignificant changes

🧪 Test Name 📏 Base 📏 Current 📈 Change 🎯 Status
Bloom Filter Dns Mutation Tracking Performance 4.29ms 4.25ms -0.8%
Bloom Filter Large Scale Dns Brute Force 18.33ms 17.73ms -3.3%
Large Closest Match Lookup 341.93ms 330.22ms -3.4%
Realistic Closest Match Workload 176.57ms 178.72ms +1.2%
Event Memory Medium Scan 1402 B/event 1402 B/event +0.0%
Event Memory Large Scan 1527 B/event 1527 B/event +0.0%
Event Validation Full Scan Startup Small Batch 412.62ms 396.72ms -3.9%
Event Validation Full Scan Startup Large Batch 507.42ms 505.68ms -0.3%
Make Event Autodetection Small 20.18ms 19.63ms -2.7%
Make Event Autodetection Large 204.64ms 200.21ms -2.2%
Make Event Explicit Types 8.44ms 8.17ms -3.1%
Excavate Single Thread Small 3.689s 3.564s -3.4%
Excavate Single Thread Large 9.252s 9.162s -1.0%
Excavate Parallel Tasks Small 3.850s 3.768s -2.1%
Excavate Parallel Tasks Large 5.867s 5.774s -1.6%
Intercept Throughput Small 860.38ms 922.85ms +7.3%
Intercept Throughput Medium 914.85ms 872.04ms -4.7%
Dns Throughput Quiet 2.450s 2.532s +3.3%
Dns Throughput Loaded 1.805s 1.645s -8.9%
Dns Throughput Inherited 2.111s 2.171s +2.9%
Is Ip Performance 2.31ms 2.25ms -2.6%
Make Ip Type Performance 195.49µs 202.29µs +3.5%
Mixed Ip Operations 2.37ms 2.33ms -1.9%
Memory Use Web Crawl 1.0 MB 1.0 MB +1.0%
Memory Use Subdomain Enum 28.3 MB 28.3 MB +0.0%
Memory Use Deep Chain 5.0 MB 5.0 MB +0.0%
Memory Use Parallel Chains 10.9 MB 9.7 MB -11.6% 🟢🟢 🚀
Scan Throughput 100 2.522s 2.569s +1.8%
Scan Throughput 1000 17.373s 17.474s +0.6%
Typical Queue Shuffle 5.28µs 5.30µs +0.4%
Priority Queue Shuffle 26.34µs 26.37µs +0.1%

🎯 Performance Summary

+ 1 improvement 🚀
  30 unchanged ✅

🔍 Significant Changes (>10%)

  • Memory Use Parallel Chains: 11.6% 🚀 less memory

🐍 Python Version 3.11.15

@codecov

codecov Bot commented Jul 9, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 90%. Comparing base (42ef254) to head (2348514).
⚠️ Report is 33 commits behind head on dev.

Files with missing lines Patch % Lines
bbot/test/test_step_1/test_validate_preset.py 91% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##             dev   #3280   +/-   ##
=====================================
+ Coverage     90%     90%   +1%     
=====================================
  Files        450     450           
  Lines      46100   46111   +11     
=====================================
+ Hits       41357   41367   +10     
- Misses      4743    4744    +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@liquidsec
liquidsec merged commit e1e6004 into dev Jul 9, 2026
24 of 27 checks passed
@liquidsec
liquidsec deleted the kitchen-sink-baddns-key branch July 9, 2026 18:49
@liquidsec liquidsec mentioned this pull request Jul 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants