Remove wpscan module - #3243
Merged
Merged
Conversation
Heavy Ruby/compiler install footprint (yajl-ruby needs gcc/make/ruby-dev), a pinned old activesupport that breaks on transitive gem drift (concurrent-ruby 1.3.5), stuck on an old wpscan line by wpscan 4.x's Ruby >=3.3 requirement, crashes instead of degrading when wpscan fails, and a test that stubbed out the binary so none of it was ever caught. Docs regeneration handled separately.
ausmaster
self-requested a review
June 24, 2026 19:38
ausmaster
approved these changes
Jun 24, 2026
Contributor
📊 Performance Benchmark Report
📈 Detailed Results (All Benchmarks)
🎯 Performance Summary! 2 regressions ⚠️
29 unchanged ✅🔍 Significant Changes (>10%)
🐍 Python Version 3.11.15 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #3243 +/- ##
======================================
+ Coverage 90% 90% +1%
======================================
Files 453 451 -2
Lines 46304 46125 -179
======================================
- Hits 41411 41270 -141
+ Misses 4893 4855 -38 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
wpscanmodule and its test. It's become too heavy and too brittle for bbot's lightweight install model:gcc,make,ruby-dev) to compile a native C extension (yajl-ruby, pulled in transitively viacms_scanner) on the user's machine. Enabling one module drags a compiler onto the host.activesupport(6.1.x). When the transitiveconcurrent-rubyreleased 1.3.5 (which dropped its implicitrequire 'logger'), wpscan stopped booting entirely withuninitialized constant ActiveSupport::LoggerThreadSafeLevel::Logger. That's a field breakage with zero changes on our side, and it recurs whenever a transitive gem floats forward.setup()returnedTrueunconditionally without verifying wpscan could run, so when it failed it raised on every event ('NoneType' object has no attribute 'stdout', orjson.loads("")on empty output), flooding scans with errors.helpers.runto return canned JSON, so it only exercised the output parser; the binary was never invoked. That's why CI stayed green while the tool was broken in the field.Removes:
bbot/modules/wpscan.pybbot/test/test_step_2/module_tests/test_module_wpscan.py