Skip mismatched protocol/port probes for well-known ports - #3234
Merged
Conversation
Contributor
🚀 Performance Benchmark Report
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #3234 +/- ##
=====================================
+ Coverage 90% 90% +1%
=====================================
Files 453 453
Lines 46101 46126 +25
=====================================
+ Hits 41211 41240 +29
+ Misses 4890 4886 -4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ausmaster
approved these changes
Jun 23, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When the http module receives an
OPEN_TCP_PORTevent, it speculatively probes bothhttp://andhttps://on that port. For well-known ports (80 and 443), this means every scan generates requests that are almost never useful:http://host:443/- plain HTTP to a TLS port. Almost always fails or returns garbage.https://host:80/- TLS handshake to a plain HTTP port. Almost always times out.These add up to a lot of wasted requests across a scan, especially with many open ports 80/443 targets. The success rate is near zero and the cost is a full request + timeout per target per mismatched combo.
This change makes the http module only probe the expected protocol for ports 80 and 443:
https://http://This only affects the speculative probing from
OPEN_TCP_PORTevents. If a user directly entershttp://host:443as a target, or such a URL is discovered naturally (from a page link, redirect, etc.), it still gets probed normally via theURL/URL_UNVERIFIEDpath.