Skip to content

Make output_modules additive, add exclude_output_modules - #3221

Merged
liquidsec merged 2 commits into
devfrom
additive-output-modules
Jun 23, 2026
Merged

Make output_modules additive, add exclude_output_modules#3221
liquidsec merged 2 commits into
devfrom
additive-output-modules

Conversation

@liquidsec

Copy link
Copy Markdown
Collaborator

Summary

  • output_modules is now purely additive -- -om discord adds discord on top of defaults (csv, txt, json), never replaces them. The old override hack in bake() silently dropped defaults when any default module name appeared in the list, which was confusing and inconsistent.
  • New -eom / --exclude-output-modules flag (and exclude_output_modules preset key / Python API param) for explicitly removing output modules, including defaults.
  • Moved python module from output/ to internal/ -- it was never a real output module; it's the Python API event bridge. Still inherits BaseOutputModule for behavioral properties (accept_dupes, scope_distance_modifier=None).
  • Fixed bake() safety check that silently re-added excluded default output modules.
  • Updated docs (output.md, index.md, dev/index.md) to document additive behavior and -eom.

Closes #3146

- output_modules is now always additive (defaults + explicit)
- Add exclude_output_modules / -eom for removing defaults
- Move python module from output/ to internal/
- Fix bake() safety check that re-added excluded defaults
@liquidsec
liquidsec requested a review from ausmaster June 19, 2026 05:35
@github-actions

Copy link
Copy Markdown
Contributor

🚀 Performance Benchmark Report

⚠️ No current benchmark data available

This might be because:

  • Benchmarks failed to run
  • No benchmark tests found
  • Dependencies missing

@codecov

codecov Bot commented Jun 19, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.29630% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90%. Comparing base (ef65b09) to head (b2f53f8).

Files with missing lines Patch % Lines
bbot/scanner/preset/preset.py 89% 2 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##             dev   #3221   +/-   ##
=====================================
+ Coverage     90%     90%   +1%     
=====================================
  Files        453     453           
  Lines      46101   46127   +26     
=====================================
+ Hits       41211   41237   +26     
  Misses      4890    4890           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@liquidsec
liquidsec merged commit d6ce231 into dev Jun 23, 2026
24 of 25 checks passed
@liquidsec
liquidsec deleted the additive-output-modules branch June 23, 2026 20:17
@ausmaster ausmaster added this to the BBOT 3.0 - blazed_elijah milestone Jun 26, 2026
@liquidsec liquidsec mentioned this pull request Jul 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants