Graceful asndb failure handling and report-phase cache fix - #3219
Merged
Conversation
Contributor
🚀 Performance Benchmark Report
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #3219 +/- ##
======================================
+ Coverage 90% 90% +1%
======================================
Files 453 453
Lines 46101 46203 +102
======================================
+ Hits 41211 41325 +114
+ Misses 4890 4878 -12 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ausmaster
self-requested a review
June 23, 2026 18:29
ausmaster
approved these changes
Jun 23, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #3215
Closes #3227
bbot -t ASN:15169): retries 3 times with a 3-second delay between attempts. If all retries fail, the scan aborts cleanly with a message directing the user to look up CIDR ranges manually and pass them directly with-t.ASNHelpertrips after 5 consecutive failures, logs a single prominent warning, and returnsUNKNOWN_ASNfor all subsequent calls without hitting the network. The scan continues without ASN enrichment data.asn_to_subnets()(used by ASN-as-target seed expansion) normalizes its input tointbefore calling asndb'slookup_asn(), matching asndb'sint-keyed LRU cache so repeated lookups hit the cache instead of the network.ASNHelperinstead of a throwaway un-keyedASNDB()client.generate_children()takes a requiredhelpersargument.report()reads ASN metadata stored duringhandle_event()instead of re-fetching it from the API. Zero network calls at end of scan.report()makes no network requests; ASN-as-target retry/abort behavior; and seed expansion through the sharedASNHelper.