Skip to content

Fix zeromq test hang - #3214

Merged
liquidsec merged 1 commit into
devfrom
fix-problematic-zeromq-test
Jun 23, 2026
Merged

Fix zeromq test hang#3214
liquidsec merged 1 commit into
devfrom
fix-problematic-zeromq-test

Conversation

@liquidsec

@liquidsec liquidsec commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • The zeromq test hung for 1200s on CI due to ZeroMQ's PUB/SUB "slow joiner" race -- messages published before the subscription propagates are silently dropped, causing socket.recv() to block forever
  • This became a consistent failure after the subprocess engine elimination made scans near-instant, shrinking the window for subscription propagation to near-zero
  • Fix: capture events by wrapping socket.send() on the module's PUB socket during the scan, which tests the same code path (handle_event -> serialize -> send) without any timing dependency
  • Verified 10/10 passes locally (vs ~80% before)

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Performance Benchmark Report

⚠️ No current benchmark data available

This might be because:

  • Benchmarks failed to run
  • No benchmark tests found
  • Dependencies missing

@codecov

codecov Bot commented Jun 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90%. Comparing base (ef65b09) to head (045fb9c).

Additional details and impacted files
@@          Coverage Diff          @@
##             dev   #3214   +/-   ##
=====================================
- Coverage     90%     90%   -0%     
=====================================
  Files        453     453           
  Lines      46101   46104    +3     
=====================================
- Hits       41211   41210    -1     
- Misses      4890    4894    +4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@liquidsec
liquidsec merged commit 8a49b45 into dev Jun 23, 2026
17 checks passed
@liquidsec
liquidsec deleted the fix-problematic-zeromq-test branch June 23, 2026 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants