Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions bbot/defaults.yml
Original file line number Diff line number Diff line change
Expand Up @@ -324,6 +324,7 @@ parameter_blacklist_prefixes:
- f5avr
- incap_
- visid_incap_
- nlbi_
- AWSALB
- utm_
- ApplicationGatewayAffinity
Expand Down
6 changes: 6 additions & 0 deletions bbot/modules/lightfuzz/submodules/crypto.py
Original file line number Diff line number Diff line change
Expand Up @@ -323,6 +323,12 @@ def _collect_keystream_candidates(self, probe_value):
# plaintext, so restricting to hex eliminates that class of FP.
if encoding != "hex":
continue
# Digit-only strings (e.g. "7276383284") are valid hex but are almost
# certainly plain decimal IDs (account numbers, zip codes, etc.). Their
# hex-decoded bytes XOR to small values that trivially pass the ascii_score
# threshold, producing false keystream-reuse findings.
if value.isdigit():
continue
if len(decoded) < 3:
continue
if decoded in seen_bytes:
Expand Down
12 changes: 12 additions & 0 deletions bbot/test/test_step_2/module_tests/test_module_lightfuzz.py
Original file line number Diff line number Diff line change
Expand Up @@ -5027,6 +5027,18 @@ def test_keystream_fp_sibling_form_fields_incremental():
assert not c.results, f"FP on sibling sequential hex form fields: {c.results}"


def test_keystream_fp_decimal_account_numbers():
"""Digit-only parameter values (account numbers, zip codes, etc.) are valid
hex but are plain decimal IDs. Their decoded bytes XOR to small values that
trivially pass the ascii_score threshold."""
c = _make_crypto_for_keystream(
"7276383284",
additional_params={"AccountName": "3767190588"},
)
c.detect_keystream_reuse("7276383284")
assert not c.results, f"FP on decimal account numbers: {c.results}"


# -- True positives: MUST fire --


Expand Down
Loading