Skip to content

retirejs: emit findings as INFO severity instead of passing through CVE severity - #3155

Merged
liquidsec merged 1 commit into
devfrom
retirejs-severity-fix
Jun 8, 2026
Merged

retirejs: emit findings as INFO severity instead of passing through CVE severity#3155
liquidsec merged 1 commit into
devfrom
retirejs-severity-fix

Conversation

@liquidsec

Copy link
Copy Markdown
Collaborator

Summary

  • retirejs was passing upstream CVE severity (e.g. HIGH, CRITICAL) as the FINDING event's own severity
  • Changed to always emit INFO severity; CVE severity remains in the description text
  • Added test assertion to verify findings always have INFO severity

Fixes #3153

@liquidsec liquidsec assigned liquidsec and ausmaster and unassigned ausmaster Jun 8, 2026
@liquidsec
liquidsec requested a review from ausmaster June 8, 2026 19:38
@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

📊 Performance Benchmark Report

Comparing dev (baseline) vs retirejs-severity-fix (current)

📈 Detailed Results (All Benchmarks)

📋 Complete results for all benchmarks - includes both significant and insignificant changes

🧪 Test Name 📏 Base 📏 Current 📈 Change 🎯 Status
Bloom Filter Dns Mutation Tracking Performance 4.17ms 4.29ms +2.8%
Bloom Filter Large Scale Dns Brute Force 17.36ms 17.42ms +0.3%
Large Closest Match Lookup 329.73ms 332.68ms +0.9%
Realistic Closest Match Workload 177.39ms 177.32ms -0.0%
Event Memory Medium Scan 1394 B/event 1395 B/event +0.1%
Event Memory Large Scan 1517 B/event 1519 B/event +0.1%
Event Validation Full Scan Startup Small Batch 373.33ms 385.76ms +3.3%
Event Validation Full Scan Startup Large Batch 507.43ms 500.86ms -1.3%
Make Event Autodetection Small 19.70ms 19.88ms +0.9%
Make Event Autodetection Large 200.46ms 199.42ms -0.5%
Make Event Explicit Types 8.06ms 8.16ms +1.3%
Excavate Single Thread Small 3.112s 3.075s -1.2%
Excavate Single Thread Large 8.601s 8.516s -1.0%
Excavate Parallel Tasks Small 3.330s 3.263s -2.0%
Excavate Parallel Tasks Large 5.849s 5.783s -1.1%
Intercept Throughput Small 1.012s 1.005s -0.7%
Intercept Throughput Medium 998.85ms 969.48ms -2.9%
Is Ip Performance 2.20ms 2.25ms +2.3%
Make Ip Type Performance 199.27µs 194.17µs -2.6%
Mixed Ip Operations 2.31ms 2.33ms +0.7%
Memory Use Web Crawl 435.8 MB 394.8 MB -9.4%
Memory Use Subdomain Enum 29.2 MB 29.2 MB -0.0%
Memory Use Deep Chain 8.6 MB 8.5 MB -0.1%
Memory Use Parallel Chains 22.6 MB 23.8 MB +4.9%
Scan Throughput 100 2.934s 2.763s -5.8%
Scan Throughput 1000 19.865s 19.793s -0.4%
Typical Queue Shuffle 5.69µs 5.31µs -6.6%
Priority Queue Shuffle 27.89µs 26.93µs -3.4%

🎯 Performance Summary

No significant performance changes detected (all changes <10%)


🐍 Python Version 3.11.15

@codecov

codecov Bot commented Jun 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90%. Comparing base (5726725) to head (93e4db1).
⚠️ Report is 2 commits behind head on dev.

Additional details and impacted files
@@          Coverage Diff          @@
##             dev   #3155   +/-   ##
=====================================
+ Coverage     90%     90%   +1%     
=====================================
  Files        441     441           
  Lines      39004   39005    +1     
=====================================
+ Hits       34911   34912    +1     
  Misses      4093    4093           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@liquidsec
liquidsec merged commit e06f8a3 into dev Jun 8, 2026
20 checks passed
@liquidsec
liquidsec deleted the retirejs-severity-fix branch June 8, 2026 20:51
@ausmaster ausmaster added this to the BBOT 3.0 - blazed_elijah milestone Jun 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants