Skip to content

Bound DNS engine caches with LRU eviction #3003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
liquidsec merged 1 commit into from
Apr 1, 2026
Merged

Bound DNS engine caches with LRU eviction #3003

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions bbot/core/helpers/dns/engine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ def __init__(self, socket_path, config={}, debug=False):
self.wildcard_ignore = []
self.wildcard_ignore = tuple([str(d).strip().lower() for d in self.wildcard_ignore])
self.wildcard_tests = self.dns_config.get("wildcard_tests", 5)
self._wildcard_cache = {}
self._wildcard_cache = LRUCache(maxsize=10000)
# since wildcard detection takes some time, This is to prevent multiple
# modules from kicking off wildcard detection for the same domain at the same time
self._wildcard_lock = NamedLock()
Expand All @@ -81,10 +81,10 @@ def __init__(self, socket_path, config={}, debug=False):
self._last_dns_success = None
self._last_connectivity_warning = time.time()
# keeps track of warnings issued for wildcard detection to prevent duplicate warnings
self._dns_warnings = set()
self._errors = {}
self._dns_warnings = LRUCache(maxsize=10000)
self._errors = LRUCache(maxsize=10000)
self._debug = self.dns_config.get("debug", False)
self._dns_cache = LRUCache(maxsize=10000)
self._dns_cache = LRUCache(maxsize=100000)

async def resolve(self, query, **kwargs):
"""Resolve DNS names and IP addresses to their corresponding results.
Expand Down Expand Up @@ -221,7 +221,7 @@ async def _resolve_hostname(self, query, **kwargs):
self.log.verbose(
f'Aborting future {rdtype} queries to "{parent}" because error count ({error_count:,}) exceeded abort threshold ({self.abort_threshold:,})'
)
self._dns_warnings.add(parent_hash)
self._dns_warnings[parent_hash] = True
return results, errors
results = await self._catch(self.resolver.resolve, query, **kwargs)
if use_cache:
Expand Down
Loading