Fix failing fedora distro test - #2908
Conversation
pyenv needs `patch` to build Python from source, but it wasn't included in the Fedora dnf install list, causing the build to fail.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #2908 +/- ##
=====================================
+ Coverage 92% 92% +1%
=====================================
Files 416 416
Lines 34398 34399 +1
=====================================
+ Hits 31356 31371 +15
+ Misses 3042 3028 -14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Fedora 43 replaces p7zip with native 7zip (v25.01), which rejects the literal -p"" argument passed via subprocess (exit code 2). The flag is unnecessary for unencrypted archives.
📊 Performance Benchmark Report
📈 Detailed Results (All Benchmarks)
🎯 Performance Summary✅ No significant performance changes detected (all changes <10%) 🐍 Python Version 3.11.14 |
|
On Fedora 43, /usr/sbin is a symlink to /usr/bin. When shutil.which("7z") resolves the executable, it may return /usr/sbin/7z. Native 7-Zip relies on argv[0] to locate its codec module (7z.so). When launched via the symlinked path, codec discovery fails, producing: All archive extractions then fail with exit code 2. Fix: Normalize the executable path by resolving directory symlinks only so the canonical path (/usr/bin/7z) is used. Preserve the binary name itself to avoid breaking virtualenv shims or intentional executable symlinks. |
…to fix-fedora-test # Conflicts: # bbot/core/helpers/misc.py
pyenv needs
patchto build Python from source, but it wasn't included in the Fedora dnf install list, causing the build to fail.