Skip to content

Revert "Separate update_event from make_event" - #2818

Closed
TheTechromancer wants to merge 1 commit into
devfrom
revert-2791-make-event-nomenclature
Closed

Revert "Separate update_event from make_event"#2818
TheTechromancer wants to merge 1 commit into
devfrom
revert-2791-make-event-nomenclature

Conversation

@TheTechromancer

Copy link
Copy Markdown
Contributor

Reverts #2791

@github-actions

github-actions Bot commented Dec 8, 2025

Copy link
Copy Markdown
Contributor

📊 Performance Benchmark Report

Comparing dev (baseline) vs revert-2791-make-event-nomenclature (current)

📈 Detailed Results (All Benchmarks)

📋 Complete results for all benchmarks - includes both significant and insignificant changes

🧪 Test Name 📏 Base 📏 Current 📈 Change 🎯 Status
Bloom Filter Dns Mutation Tracking Performance 4.27ms 4.30ms +0.7%
Bloom Filter Large Scale Dns Brute Force 18.39ms 18.44ms +0.3%
Large Closest Match Lookup 357.97ms 354.92ms -0.9%
Realistic Closest Match Workload 193.30ms 198.05ms +2.5%
Event Validation Full Scan Startup Small Batch 450.45ms 464.70ms +3.2%
Event Validation Full Scan Startup Large Batch 801.11ms 826.39ms +3.2%
Make Event Autodetection Small 31.44ms 31.41ms -0.1%
Make Event Autodetection Large 319.37ms 318.96ms -0.1%
Make Event Explicit Types 13.95ms 14.01ms +0.4%
Excavate Single Thread Small 4.050s 4.095s +1.1%
Excavate Single Thread Large 9.531s 9.533s +0.0%
Excavate Parallel Tasks Small 4.170s 4.210s +0.9%
Excavate Parallel Tasks Large 7.059s 7.211s +2.2%
Is Ip Performance 3.18ms 3.20ms +0.7%
Make Ip Type Performance 11.66ms 11.82ms +1.4%
Mixed Ip Operations 4.50ms 4.56ms +1.2%
Typical Queue Shuffle 62.08µs 61.86µs -0.4%
Priority Queue Shuffle 698.97µs 702.42µs +0.5%

🎯 Performance Summary

No significant performance changes detected (all changes <10%)


🐍 Python Version 3.11.14

@codecov

codecov Bot commented Dec 8, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.50000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 92%. Comparing base (c977c26) to head (8321586).

Files with missing lines Patch % Lines
bbot/core/event/base.py 90% 6 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##             dev   #2818   +/-   ##
=====================================
- Coverage     92%     92%   -0%     
=====================================
  Files        411     411           
  Lines      34044   34013   -31     
=====================================
- Hits       31064   31033   -31     
  Misses      2980    2980           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@liquidsec
liquidsec deleted the revert-2791-make-event-nomenclature branch June 10, 2026 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant