Skip to content

Clean up watchdog tasks on scan exit - #2783

Merged
TheTechromancer merged 1 commit into
devfrom
fix-uncleanedup-watchdogs
Nov 18, 2025
Merged

Clean up watchdog tasks on scan exit#2783
TheTechromancer merged 1 commit into
devfrom
fix-uncleanedup-watchdogs

Conversation

@TheTechromancer

Copy link
Copy Markdown
Contributor

Minor housekeeping as these tasks weren't being cleaned up properly.

@github-actions

Copy link
Copy Markdown
Contributor

📊 Performance Benchmark Report

Comparing dev (baseline) vs fix-uncleanedup-watchdogs (current)

📈 Detailed Results (All Benchmarks)

📋 Complete results for all benchmarks - includes both significant and insignificant changes

🧪 Test Name 📏 Base 📏 Current 📈 Change 🎯 Status
Bloom Filter Dns Mutation Tracking Performance 4.19ms 4.25ms +1.4%
Bloom Filter Large Scale Dns Brute Force 18.05ms 18.20ms +0.8%
Large Closest Match Lookup 358.61ms 347.35ms -3.1%
Realistic Closest Match Workload 195.17ms 194.44ms -0.4%
Event Validation Full Scan Startup Small Batch 459.03ms 467.94ms +1.9%
Event Validation Full Scan Startup Large Batch 807.80ms 811.63ms +0.5%
Make Event Autodetection Small 31.37ms 31.21ms -0.5%
Make Event Autodetection Large 318.81ms 319.30ms +0.2%
Make Event Explicit Types 13.95ms 14.05ms +0.7%
Excavate Single Thread Small 7.951s 4.107s -48.3% 🟢🟢🟢 🚀
Excavate Single Thread Large 9.607s 9.669s +0.6%
Excavate Parallel Tasks Small 4.289s 4.276s -0.3%
Excavate Parallel Tasks Large 7.187s 7.182s -0.1%
Is Ip Performance 3.19ms 3.17ms -0.4%
Make Ip Type Performance 11.35ms 11.48ms +1.1%
Mixed Ip Operations 4.54ms 4.52ms -0.4%
Typical Queue Shuffle 62.07µs 62.53µs +0.7%
Priority Queue Shuffle 698.01µs 705.47µs +1.1%

🎯 Performance Summary

+ 1 improvement 🚀
  17 unchanged ✅

🔍 Significant Changes (>10%)

  • Excavate Single Thread Small: 48.3% 🚀 faster

🐍 Python Version 3.11.14

@codecov

codecov Bot commented Nov 18, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92%. Comparing base (55f68e5) to head (66d0018).
⚠️ Report is 2 commits behind head on dev.

Additional details and impacted files
@@          Coverage Diff          @@
##             dev   #2783   +/-   ##
=====================================
- Coverage     92%     92%   -0%     
=====================================
  Files        410     410           
  Lines      33933   33933           
=====================================
- Hits       30983   30966   -17     
- Misses      2950    2967   +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@TheTechromancer
TheTechromancer merged commit 2c4f5dd into dev Nov 18, 2025
14 of 17 checks passed
@liquidsec liquidsec mentioned this pull request Jun 9, 2026
@liquidsec
liquidsec deleted the fix-uncleanedup-watchdogs branch June 10, 2026 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants