Skip to content

Fix finding sanitization - #2782

Merged
TheTechromancer merged 2 commits into
3.0from
fix-finding-netloc
Nov 17, 2025
Merged

Fix finding sanitization#2782
TheTechromancer merged 2 commits into
3.0from
fix-finding-netloc

Conversation

@TheTechromancer

@TheTechromancer TheTechromancer commented Nov 17, 2025

Copy link
Copy Markdown
Contributor

After the vuln/finding merge, finding port + host wasn't working properly due to a bug in sanitization. This PR fixes it.

@github-actions

Copy link
Copy Markdown
Contributor

📊 Performance Benchmark Report

Comparing 3.0 (baseline) vs fix-finding-netloc (current)

📈 Detailed Results (All Benchmarks)

📋 Complete results for all benchmarks - includes both significant and insignificant changes

🧪 Test Name 📏 Base 📏 Current 📈 Change 🎯 Status
Bloom Filter Dns Mutation Tracking Performance 4.19ms 4.22ms +0.8%
Bloom Filter Large Scale Dns Brute Force 17.58ms 18.19ms +3.4%
Large Closest Match Lookup 357.82ms 356.07ms -0.5%
Realistic Closest Match Workload 194.59ms 193.45ms -0.6%
Event Validation Full Scan Startup Small Batch 471.96ms 475.75ms +0.8%
Event Validation Full Scan Startup Large Batch 802.38ms 808.49ms +0.8%
Make Event Autodetection Small 30.95ms 31.16ms +0.7%
Make Event Autodetection Large 312.32ms 316.71ms +1.4%
Make Event Explicit Types 13.68ms 13.74ms +0.4%
Excavate Single Thread Small 4.013s 4.079s +1.6%
Excavate Single Thread Large 9.441s 9.412s -0.3%
Excavate Parallel Tasks Small 4.199s 4.290s +2.2%
Excavate Parallel Tasks Large 7.111s 7.173s +0.9%
Is Ip Performance 3.20ms 3.18ms -0.5%
Make Ip Type Performance 11.48ms 11.41ms -0.6%
Mixed Ip Operations 4.55ms 4.52ms -0.7%
Typical Queue Shuffle 61.45µs 62.22µs +1.3%
Priority Queue Shuffle 707.68µs 702.84µs -0.7%

🎯 Performance Summary

No significant performance changes detected (all changes <10%)


🐍 Python Version 3.11.14

@TheTechromancer
TheTechromancer merged commit fd9138b into 3.0 Nov 17, 2025
10 of 14 checks passed
@codecov

codecov Bot commented Nov 17, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92%. Comparing base (da75243) to head (ca85d83).
⚠️ Report is 6 commits behind head on 3.0.

Additional details and impacted files
@@          Coverage Diff          @@
##             3.0   #2782   +/-   ##
=====================================
- Coverage     92%     92%   -0%     
=====================================
  Files        426     426           
  Lines      34632   34639    +7     
=====================================
+ Hits       31599   31604    +5     
- Misses      3033    3035    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant