Skip to content

New Module: retire.js - #2617

Merged
liquidsec merged 22 commits into
devfrom
retire-js
Aug 27, 2025
Merged

New Module: retire.js#2617
liquidsec merged 22 commits into
devfrom
retire-js

Conversation

@liquidsec

@liquidsec liquidsec commented Aug 19, 2025

Copy link
Copy Markdown
Collaborator

This adds a new module: retire.js, which instruments the retire.js tool to find vulnerabilities in JS files.

It also changes how .js URLs are handled, it actually fixes a previously unknown bug where .js files weren't being delivered to httpx.

It also adds emergency timeouts to multi-processing tests, which briefly decided to cause problems during development of this. Now they will at least not run for 6 hours if theres another problem.

  • Add a severity filter

@liquidsec
liquidsec marked this pull request as draft August 19, 2025 18:51
@liquidsec
liquidsec marked this pull request as ready for review August 21, 2025 19:18
@codecov

codecov Bot commented Aug 21, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 88.95349% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 93%. Comparing base (c221e5d) to head (2bad2b4).
⚠️ Report is 64 commits behind head on dev.

Files with missing lines Patch % Lines
bbot/modules/retirejs.py 89% 11 Missing ⚠️
...t/test_step_2/module_tests/test_module_retirejs.py 90% 6 Missing ⚠️
bbot/scanner/manager.py 60% 2 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##             dev   #2617    +/-   ##
======================================
- Coverage     93%     93%    -0%     
======================================
  Files        402     404     +2     
  Lines      33268   33421   +153     
======================================
+ Hits       30774   30889   +115     
- Misses      2494    2532    +38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread bbot/modules/retirejs.py Outdated
Comment thread bbot/modules/retirejs.py Outdated
@liquidsec
liquidsec requested a review from TMDeal August 26, 2025 19:41

@aconite33 aconite33 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me (tm)

@liquidsec
liquidsec merged commit 8a6bdba into dev Aug 27, 2025
21 of 23 checks passed
@liquidsec
liquidsec deleted the retire-js branch August 27, 2025 14:45

@TMDeal TMDeal left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants