Skip to content

Fix missing massdns dependency in dnscommonsrv #2511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheTechromancer merged 3 commits into from
Jun 26, 2025
Merged

Fix missing massdns dependency in dnscommonsrv #2511

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2124bcc
add missing massdns dependency
invalid-email-address Jun 25, 2025
6034dd8
stringify command
invalid-email-address Jun 26, 2025
9c756ad
fix tests
invalid-email-address Jun 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion bbot/core/helpers/command.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,9 @@ async def _spawn_proc(self, *command, **kwargs):
try:
command, kwargs = self._prepare_command_kwargs(command, kwargs)
except SubprocessError as e:
log.warning(e)
command_str = " ".join(command)
log.warning(f"Error running command: '{command_str}': {e}")
log.trace(traceback.format_exc())
return None, None, None
_input = kwargs.pop("input", None)
if _input is not None:
Expand Down
1 change: 1 addition & 0 deletions bbot/modules/dnscommonsrv.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ class dnscommonsrv(subdomain_enum):
flags = ["subdomain-enum", "active", "safe"]
meta = {"description": "Check for common SRV records", "created_date": "2022-05-15", "author": "@TheTechromancer"}
dedup_strategy = "lowest_parent"
deps_common = ["massdns"]

options = {"max_depth": 2}
options_desc = {"max_depth": "The maximum subdomain depth to brute-force SRV records"}
Expand Down