Fix broken chromium on M4 Mac - #2487
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #2487 +/- ##
=======================================
+ Coverage 93% 93% +1%
=======================================
Files 383 398 +15
Lines 30165 33075 +2910
=======================================
+ Hits 27884 30582 +2698
- Misses 2281 2493 +212 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@mukesh-dream11 that's a good option to have, thanks for adding it! Before we merge I want to make a few edits; can you enable editing? I think the option is called Allow edits from maintainers: |
|
@TheTechromancer done |
|
@TheTechromancer I will be pushing few changes of my own within the next hour. I realize this PR is not production-ready. |
|
@mukesh-dream11 let me know once this is ready for review |
|
@TheTechromancer that would be it from my side. Adding a I've tried my best to fix test case failures, but this is ready for your review. |
|
@mukesh-dream11 I built on your changes and tweaked it a bit. You wanna test it out? |
|
@TheTechromancer will test it out and update within the next 24 hours |
|
@TheTechromancer I tried this PR out with no custom
I fixed both of these, so please take a look. Running bbot without a |
|
Approved. @mukesh-dream11 with all your recent work on BBOT I think you've earned some black lantern swag. If you're interested DM me on X or Discord 🧡 |

This PR introduces a new option,
chrome_pathin the configuration YAML file for thegowitnessmodule. This can be used to add a customchrome_pathvariable to use an existing Chrom(e/ium) installation.