Skip to content

Fix broken chromium on M4 Mac - #2487

Merged
TheTechromancer merged 8 commits into
blacklanternsecurity:devfrom
mukesh-dream11:stable
Jun 8, 2025
Merged

Fix broken chromium on M4 Mac#2487
TheTechromancer merged 8 commits into
blacklanternsecurity:devfrom
mukesh-dream11:stable

Conversation

@mukesh-dream11

Copy link
Copy Markdown
Contributor

This PR introduces a new option, chrome_path in the configuration YAML file for the gowitness module. This can be used to add a custom chrome_path variable to use an existing Chrom(e/ium) installation.

@TheTechromancer
TheTechromancer changed the base branch from stable to dev June 3, 2025 14:03
@codecov

codecov Bot commented Jun 3, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 53.33333% with 14 lines in your changes missing coverage. Please review.

Project coverage is 93%. Comparing base (a09d9c3) to head (dfef2c9).
Report is 618 commits behind head on dev.

Files with missing lines Patch % Lines
bbot/modules/gowitness.py 52% 14 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             dev   #2487     +/-   ##
=======================================
+ Coverage     93%     93%     +1%     
=======================================
  Files        383     398     +15     
  Lines      30165   33075   +2910     
=======================================
+ Hits       27884   30582   +2698     
- Misses      2281    2493    +212     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@TheTechromancer

Copy link
Copy Markdown
Contributor

@mukesh-dream11 that's a good option to have, thanks for adding it! Before we merge I want to make a few edits; can you enable editing? I think the option is called Allow edits from maintainers:

image

@mukesh-dream11

Copy link
Copy Markdown
Contributor Author

@TheTechromancer done

@mukesh-dream11

Copy link
Copy Markdown
Contributor Author

@TheTechromancer I will be pushing few changes of my own within the next hour. I realize this PR is not production-ready.

@TheTechromancer

Copy link
Copy Markdown
Contributor

@mukesh-dream11 let me know once this is ready for review

@mukesh-dream11

Copy link
Copy Markdown
Contributor Author

@TheTechromancer that would be it from my side.

Adding a chrome_path makes it work on my laptop, but running bbot out-of-box without the chrome_path option still fails. I'm on an M4 Mac. this might be related to the tool download / installation tasks but I've not had time to look at it.

I've tried my best to fix test case failures, but this is ready for your review.

@TheTechromancer

Copy link
Copy Markdown
Contributor

@mukesh-dream11 I built on your changes and tweaked it a bit. You wanna test it out?

@TheTechromancer TheTechromancer self-assigned this Jun 5, 2025
@mukesh-dream11

Copy link
Copy Markdown
Contributor Author

@TheTechromancer will test it out and update within the next 24 hours

@mukesh-dream11

Copy link
Copy Markdown
Contributor Author

@TheTechromancer I tried this PR out with no custom chrome_path and it just fails on my Mac. Even trying --force-deps didn't work because of two reasons:

  1. --force-deps was not being respected for common dependencies
  2. The ansible playbook for installing chromium didn't include sections for Macs

I fixed both of these, so please take a look.

Running bbot without a chrome_path on Macs should work now.

@TheTechromancer
TheTechromancer merged commit 340ce4c into blacklanternsecurity:dev Jun 8, 2025
@TheTechromancer

Copy link
Copy Markdown
Contributor

Approved. @mukesh-dream11 with all your recent work on BBOT I think you've earned some black lantern swag. If you're interested DM me on X or Discord 🧡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants