Keep the dict sorted by keys to spot two duplicates #1998
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep dict keys sorted to make it easy to spot missing keys and nearly impossible to insert duplicates.
%
ruff check bbot/core/helpers/libmagic.py
%
ruff rule F601
multi-value-repeated-key-literal (F601)
Derived from the Pyflakes linter.
Fix is sometimes available.
What it does
Checks for dictionary literals that associate multiple values with the
same key.
Why is this bad?
Dictionary keys should be unique. If a key is associated with multiple values,
the earlier values will be overwritten. Including multiple values for the
same key in a dictionary literal is likely a mistake.
Example
Use instead:
References