Closes #25 - Added MySQL prepost strategy & documentation #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,11 @@ | |||
| source /prexecute/utils/check-env.sh | |||
|
|
|||
| if [ "$BACKUP_TYPE" = "backup" ] || [ "$BACKUP_TYPE" = "backupIncremental" ] || [ "$BACKUP_TYPE" = "backupFull" ]; then | |||
There was a problem hiding this comment.
You should use a case directive here: http://tldp.org/LDP/Bash-Beginners-Guide/html/sect_07_03.html
| ## | ||
| function _check_env_failed { | ||
| echo "[!] ENV VAR $1 IS NOT SET" | ||
| printf "\n====ENVIRONMENT VARIABLES FAILED====\n\n" |
There was a problem hiding this comment.
This is called flagging - Clean Code. Do not use upper case chars and symbolic characters in order to make it appear better on logs. Does not work when everybody documents like that.
|
Thanks for the example. Please take a note of my comments. Correction is not required. |
|
In my use case I also need a MongoDB strategy, tomorrow when i do it i can also push it as another example and i can fix the problems pointed in your comments. For the second comment how would you do it? Without all the fancy symbolic characters and in lowercase? |
SrZorro
added a commit
to SrZorro/volumerize
that referenced
this pull request
Jun 8, 2018
…so corrected comments from pull blacklabelops#26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.