Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Convert subs when download is skipped #94

Merged
merged 2 commits into from
Sep 13, 2020

Conversation

blackjack4494
Copy link
Owner

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

Explanation of your pull request in arbitrary form goes here. Please make sure the description explains the purpose and effect of your pull request and is worded well enough to be understood. Provide as much context and examples as possible.

#86
ytdl-org#22869

@blackjack4494 blackjack4494 merged commit ef0389f into master Sep 13, 2020
@blackjack4494 blackjack4494 mentioned this pull request Sep 13, 2020
@blackjack4494 blackjack4494 changed the title [youtube] Convert subs when download is skipped [Core] Convert subs when download is skipped Oct 2, 2020
@blackjack4494
Copy link
Owner Author

@hamidb80
Normal youtube-dl won't download subtitles when used with skip download.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant