feat: migration to typescript (wip) #1072
Conversation
|
Ok, everything works high-level now. Time to comb through everything in detail, clean-up and make it pretty! |
| @blackflux/robo-config-plugin | ||
| @tsconfig/node14 | ||
| ts-loader | ||
| ts-node |
There was a problem hiding this comment.
Are these all needed?
| @@ -1 +1,4 @@ | |||
| timeout: 2000 | |||
| node-option: | |||
| - experimental-specifier-resolution=node | |||
| "clean": "rm -rf lib", | ||
| "build": "cp -rf ./src ./lib && ncc build -m -o lib && mv lib/index.js lib/index.min.js && cp src/index.js lib/index.js && rm lib/package.json", | ||
| "compile": "tsc -p tsconfig.json", | ||
| "build": "cp -rf ./src ./lib && ncc build -m -o lib && mv lib/index.ts lib/index.min.ts && mv lib/index.js lib/index.min.js && cp src/index.ts lib/index.ts && rm lib/package.json", |
There was a problem hiding this comment.
Do we need build and compile? What is the difference?
| "build": "cp -rf ./src ./lib && ncc build -m -o lib && mv lib/index.ts lib/index.min.ts && mv lib/index.js lib/index.min.js && cp src/index.ts lib/index.ts && rm lib/package.json", | ||
| "build-clean": "yarn run clean && yarn run build", | ||
| "test-simple": "c8 mocha --experimental-loader=./test/hot.js \"./test/**/*.spec.js\"", | ||
| "test-simple": "c8 mocha --experimental-loader=./test/hot.js \"./test/**/*.spec.ts\"", |
There was a problem hiding this comment.
Should this include all file extensions?
| "treeify": "1.1.0", | ||
| "ts-loader": "9.3.1", | ||
| "ts-node": "10.9.1", | ||
| "typescript": "4.7.4" |
There was a problem hiding this comment.
Are all these deps required?
| @@ -0,0 +1,57 @@ | |||
| // @ts-ignore | |||
There was a problem hiding this comment.
Way too many ts-ignore here. How can we get rid of all / most?
| const eslint = new ESLint({ | ||
| cwd: dir, | ||
| // todo: fix | ||
| fix: false, |
There was a problem hiding this comment.
Detect cmd arg and set this to true or false here
| @@ -0,0 +1,24 @@ | |||
| { | |||
| "compilerOptions": { "strict": true }, | |||
| @@ -0,0 +1,24 @@ | |||
| { | |||
| "compilerOptions": { "strict": true }, | |||
| "extends": "./tsconfig.json", | |||
There was a problem hiding this comment.
What does this do? Do we need it?
| @@ -0,0 +1,33 @@ | |||
| { | |||
| "include": [ | |||
| "./src/**/*" | |||
There was a problem hiding this comment.
Is this too permissive? Still not clear what we need here? I'm assuming this works together with the compile command?
|
is this pr still active? @simlu |
|
Ops accidentally hit the wrong button. Yes,it is still active! All the major work has been done. Just need to do an in-depth review and fix up. Then abstract it. Just haven't gotten to continuing this. Life got busy... |
3 participants
No description provided.