fix: some parameters should be required in import-specification and deployment command #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eployment command
wenytang-ms
approved these changes
Jun 3, 2024
Collaborator
|
may need ut |
Owner
Author
Thanks. The UT cannot capture the help message so I can't add test cases for the changes :( |
blackchoey
added a commit
that referenced
this pull request
Jul 17, 2024
* build: add cicd pipeline (#7) * build: move update version logic to workflow (#8) * build: Run CI on multiple python version (#38) * build: Run CI in Python 3.8-3.11 * build: remove pull request event for CI to avoid duplicate runs * test: add test cases for commands (#40) * fix: error when register API with long description spec (#41) * test: add test cases for optional parameters (#42) * feat!: remove file name param (#43) * fix: error not thrown when import spec with >3MB file (#44) * feat!: remove state param for deployment commands (#46) * fix: API title created by register command is not same with provided spec (#47) * feat!: redesign parameters to specify APIM instance for import-from-apim command (#45) * test: clean up legacy test cases (#48) * test: add test cases for command examples (#49) * docs: update help message per feedback (#50) * build: bump version to 1.0.0 and add changelog (#51) * fix: some parameters should be required in import-specification and deployment command (#53) * feat!: rename parameter names to align with other Azure CLI command experience (#52) * test: enable test for import-from-apim (#54) * test: fix show service test case (#55) * docs: update changelog for 1.0.0 (#56) * Update HISTORY.rst - jukasper updated changelog * Update HISTORY.rst * Update HISTORY.rst * Update HISTORY.rst * Update HISTORY.rst * Update HISTORY.rst * Update HISTORY.rst * Update HISTORY.rst * Update HISTORY.rst * Update HISTORY.rst * Update HISTORY.rst * Update HISTORY.rst * Update HISTORY.rst * Update HISTORY.rst * Update HISTORY.rst * Update HISTORY.rst * Update HISTORY.rst * docs: update readme for apic-extension (#57) * fix: cannot run create command against existing resource (#58) * fix: cannot run create command against existing resource * style: fix style * build: remove cicd pipeline (#59) * build: resolve review comments (#60) --------- Co-authored-by: Julia Kasper <[email protected]>
frankqianms
pushed a commit
that referenced
this pull request
Aug 4, 2025
* Upstream Merge * Merge from workload-orchestration : Added Example in Description (#34) * Merge from workload-orchestration : Fixed Example * Fixed Example for SolutionTemplateVersion * Made Changes for command-change CI fix' * Reset Version 1.0.0b1 * Added Bulk and Diagnostics Back (#35) Co-authored-by: Atharva Udapure <[email protected]> * Added Bulk Solution Example (#36) * Added Bulk and Diagnostics Back * Changes --------- Co-authored-by: Atharva Udapure <[email protected]> * Fixed Solution Template Linter Issue * Added Integration Tests Framework for WorkloadOrchestration #37 Co-authored-by: Atharva Udapure <[email protected]> * Added ServiceName (#38) * Added Tests * Made Changes on ServiceName --------- Co-authored-by: Atharva Udapure <[email protected]> * Added Full Target Solution Tests (#39) * Added Tests * Made Changes on ServiceName * Nit Changes * Made Changes for ContextLookup --------- Co-authored-by: Atharva Udapure <[email protected]> * Added E2E workflow Tests (#40) * Added Tests * Made Changes on ServiceName * Nit Changes * Made Changes for ContextLookup * Added complete workflow * Add Licence * Added License --------- Co-authored-by: Atharva Udapure <[email protected]> * Added Readme (#41) Co-authored-by: Atharva Udapure <[email protected]> * Bulk Deployemnent LRO changes (#42) * made changes * Added change * Added Changes in Test * Added CLi Changes * Added Setup --------- Co-authored-by: Atharva Udapure <[email protected]> * Added Changes For Backward Compitablity (#43) * Added Changes For Backward Compitablity * Made changes --------- Co-authored-by: Atharva Udapure <[email protected]> * Made changes (#44) Co-authored-by: Atharva Udapure <[email protected]> * Target Operations API refractoring (#47) * Changes I made * Make changes * Made chnages * Make changes --------- Co-authored-by: Atharva Udapure <[email protected]> * Stable API 2025-06-01 (#48) * Made changes * Made Changes --------- Co-authored-by: Atharva Udapure <[email protected]> * Change in ID in Targets (#50) * Made changes * changes --------- Co-authored-by: Atharva Udapure <[email protected]> * Remove Id and Name from Target Review (#51) Co-authored-by: Atharva Udapure <[email protected]> * final bulk (#52) Co-authored-by: Atharva Udapure <[email protected]> * Changes in ARG * Added Linter Exception * Added ITTests (#53) Co-authored-by: Atharva Udapure <[email protected]> * Standardize CLI (#54) * Made Changes * Made Changes * Made changes * Added Change * Made changes * Made changes * Made changes * Made Changes --------- Co-authored-by: Atharva Udapure <[email protected]> * Linter FIxes and Remove Preview * Removed Resolved from CLI * change in version * made changes (#55) Co-authored-by: Atharva Udapure <[email protected]> * Fixed history --------- Co-authored-by: Atharva Udapure <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--definition-id,--environment-id,--server,--titleparameters should be required inaz apic api deployment createcommand--format,--specification,--valueparameters should be required inaz apic api definition import-specificationcommandhttps://msazure.visualstudio.com/One/_workitems/edit/28011693
https://msazure.visualstudio.com/One/_workitems/edit/28042590