Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Artist top songs (from lastfm) #229

Draft
wants to merge 13 commits into
base: master
Choose a base branch
from
Draft

Artist top songs (from lastfm) #229

wants to merge 13 commits into from

Conversation

Scaffale
Copy link

@Scaffale Scaffale commented Dec 2, 2022

  • Add migration to insert lasfm api key
  • Update db schema
  • Inserted setting api_key for lastfm in setting view
  • Add button with songs list. Lasfm model query lastfm (now with just top songs) for the song list.
  • Add render_async gem to avoid lastm interaction blocking resource load
  • Updated test
  • Add test for models
  • Add test
  • Update with master
  • Merge with master
  • test fix
  • Add if condition to show top_tracks
  • Add case for lastfm error.

mgiacchetti added 13 commits November 21, 2022 17:02
Add migration to insert lasfm api key
45b4d93
Update db schema
103b203
Inserted setting api_key for lastfm in setting view
c7707b9
Add <play top songs> button with songs list.
fb5c8ee 
Lasfm model query lastfm (now with just top songs) for the song list.
Add render_async gem to avoid lastm interaction blocking resource load
c532caa
Updated test
ba4c1f3
Add test for models
ad17bf8
Add test
5a922bb
Update with master
0b8a931 
Squashed commit of the following:

commit 065d48f
Merge: 4f04748 a7b2e57
Author: Ed <[email protected]>
Date:   Tue Nov 22 16:11:44 2022 +0800

    Merge pull request blackcandy-org#223 from blackcandy-org/remove-nginx-dependence

    Make nginx become optional

commit a7b2e57
Author: aidewoode <[email protected]>
Date:   Tue Nov 22 16:03:40 2022 +0800

    Use Rack::File to support HTTP range without nginx

commit 776895b
Author: aidewoode <[email protected]>
Date:   Tue Nov 22 10:55:12 2022 +0800

    Remove nginx from default stack

commit eee79d7
Author: aidewoode <[email protected]>
Date:   Fri Nov 18 15:06:52 2022 +0800

    Fix config issue in production environment
Merge with master
7a042e6 
Squashed commit of the following:

commit 8a10801
Author: Ed <[email protected]>
Date:   Wed Nov 30 17:03:15 2022 +0800

    Update README.md

commit 4ab5e08
Merge: 85d128a 10fb16d
Author: Ed <[email protected]>
Date:   Wed Nov 30 11:25:31 2022 +0800

    Merge pull request blackcandy-org#228 from blackcandy-org/dev

    Dev

commit 10fb16d
Author: aidewoode <[email protected]>
Date:   Wed Nov 30 10:58:29 2022 +0800

    Ensure reset state of syncing when complete sync

commit 7fa139a
Author: aidewoode <[email protected]>
Date:   Wed Nov 30 09:59:50 2022 +0800

    Fix type issue on attribute of is_favorited

commit 630b0ab
Author: aidewoode <[email protected]>
Date:   Mon Nov 28 15:42:44 2022 +0800

    Update docker-compose file for PWD

commit 9edf391
Author: aidewoode <[email protected]>
Date:   Mon Nov 28 15:00:52 2022 +0800

    Update README for edge version

commit 85d128a
Merge: 46af7ba 4358a82
Author: Ed <[email protected]>
Date:   Fri Nov 25 16:52:46 2022 +0800

    Merge pull request blackcandy-org#227 from blackcandy-org/dev

    Fix build error of docker image

commit 4358a82
Author: aidewoode <[email protected]>
Date:   Fri Nov 25 16:37:39 2022 +0800

    Fix build error of docker image

commit 46af7ba
Merge: 065d48f 5d3e48b
Author: Ed <[email protected]>
Date:   Fri Nov 25 13:57:36 2022 +0800

    Merge pull request blackcandy-org#226 from blackcandy-org/dev

    Add app config management

commit 5d3e48b
Author: aidewoode <[email protected]>
Date:   Fri Nov 25 13:50:09 2022 +0800

    Fix some fragile system tests

commit 2efc6fb
Author: aidewoode <[email protected]>
Date:   Fri Nov 25 11:24:45 2022 +0800

    Add black candy config to set app config easily

commit 8d1fbcc
Author: aidewoode <[email protected]>
Date:   Wed Nov 23 10:52:37 2022 +0800

    Remove dotenv

commit 086f8a8
Author: aidewoode <[email protected]>
Date:   Tue Nov 22 16:38:30 2022 +0800

    Remove devcontainer

commit 065d48f
Merge: 4f04748 a7b2e57
Author: Ed <[email protected]>
Date:   Tue Nov 22 16:11:44 2022 +0800

    Merge pull request blackcandy-org#223 from blackcandy-org/remove-nginx-dependence

    Make nginx become optional

commit a7b2e57
Author: aidewoode <[email protected]>
Date:   Tue Nov 22 16:03:40 2022 +0800

    Use Rack::File to support HTTP range without nginx

commit 776895b
Author: aidewoode <[email protected]>
Date:   Tue Nov 22 10:55:12 2022 +0800

    Remove nginx from default stack

commit eee79d7
Author: aidewoode <[email protected]>
Date:   Fri Nov 18 15:06:52 2022 +0800

    Fix config issue in production environment
test fix
a1488f1
Add if condition to show top_tracks
6fcfc05
Add case for lastfm error.
281f3d0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Scaffale