[ruleset-verify] Test required-check enforcement — close without merging#3
Closed
larsweiser wants to merge 1 commit into
Closed
[ruleset-verify] Test required-check enforcement — close without merging#3larsweiser wants to merge 1 commit into
larsweiser wants to merge 1 commit into
Conversation
Collaborator
Author
|
Verification complete. The protect-main ruleset's required-status-check rule blocks merge as designed: |
larsweiser
pushed a commit
that referenced
this pull request
Apr 28, 2026
Two new sections between "Implementation phasing" and "Skills": - "Gate-based handoff pattern" — four rules on how to sequence work with Claude: plan-first for multi-decision tasks, pause at named gates, report diagnostics before editing, surface uncertainty as open questions rather than silent guesses. The discipline Pass 1 shipped on. - "Process rules from Pass 1" — three specific technical lessons extracted from bugs we caught during G1b / G4 / post-deploy: token-conversion verification scope (diff both preset and companion CSS), wrangler env-inheritance gotcha (observability / vars / routes don't inherit into env.* blocks), and primary- source verification for version-dependent API behavior. Closes items #2, #3 of the Pass 2 backlog (which also had them scheduled for a CLAUDE.md touch at Pass 2 start; landing them now keeps the rules in the file when the next session picks up). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
blackbrowed-labs
added a commit
that referenced
this pull request
Apr 29, 2026
…failures" design
Adds verify-cloudflare-facts.yml weekly cron workflow + scripts/checks/dpf.mjs
+ scripts/checks/cwa-retention.mjs + 6 fixtures + scripts/run-verifier.mjs
orchestrator. Extends scripts/check-cloudflare-facts-freshness.mjs to read
_meta.last_check_attempt with 30-day threshold (down from 90).
Migrates src/data/cloudflare-facts.json to verifier-era schema (schema_version
1; per-fact status + value fields; _meta block; structured cwa_retention with
integer month values; raw_events_retention_months explicitly null per
Cloudflare's documented absence). Updates src/lib/cloudflare-facts.ts type +
adds getEffectiveVerifiedDate helper (worst-case freshness signal: older of
the two per-fact verified_at). Privacy pages (datenschutz.astro, en/privacy.astro)
read via the helper.
Verifier shape per plans/active/pass-2/g-d-2/spec.md: 1/5/15-min retry budget
(21 min total, fits 30-min workflow timeout); status-return error handling
(no throws cross check boundaries); explicit registry per spec §9.6;
hand-written validator per §9.7; status-enum rename ('ok' CheckResult →
'active' JSON) per §6.2; v1-coverage smoke step inside verifier workflow only,
mode #8 deploy-triggered limitation acknowledged per §3.8.
All synthetic failure modes (#2, #4, #5, #6) verified via MOCK_SCENARIO=
fixture routing. Mode #1 (freshness gate) verified via stale last_check_attempt.
Modes #3, #7, #8, #9 deferred to controller-side post-commit per prompt's
"may defer" guidance. Outcome record at
plans/active/pass-2/g-d-7/verifier-test-matrix.md (workspace, gitignored).
Closes backlog #8.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test PR to verify that the
protect-mainruleset's required-status-check rule blocks merges untilbuild-prreports success.This branch intentionally doesn't carry
ci-pr.yml, so the workflow won't run and the required check will remain pending — proving the rule is active. Will be closed without merging once verified.