Make fill form shortcuts optional #46
Conversation
|
IMHO it should be removed, because after pondering a bit about it I feel it is a security risk to randomly try to select another window on the desktop and then insert secret information. I still feel that |
User can add -DDISABLE_FILL_FORM_SHORTCUTS=1 to CMake configure command
line to disable fill form shortcuts in the build.
- set compile definition DISABLE_FILL_FORM_SHORTCUTS
- add message if shortcuts are enabled or not
- move add_subdirectory() calls towards the end of the file so that they
can rely on find_package()-generated flags.
- wrap everything related to class Keypress implementation with
if (NOT DISABLE_FILL_FORM_SHORTCUTS)
...
endif()
- move X11 libraries linking to conditional branch under src/
Fixes bkueng#32
Fedora 40 will switch to KDE Plasma 6 and no longer offer a X11 session, i.e. Qt programs will definitely run on Wayland. Therefore we should remove all X11 dependencies as the fill form shortcuts do not work on Wayland anyway... - factor out X11 packages to environment variables - do not install X11 packages when flag is set - add -DDISABLE_FILL_FORM_SHORTCUTS=1 to configure step when flag is set
stefanb2
force-pushed
the
topic-make-x11-dependency-optional
branch
from
b84596d to
81df8bb
Compare
I agree it demands a bit more from the user. But how (if at all) do you see it as more of a security risk than going through the clipboard? |
In the sense that CTRL-TAB selects the wrong window, f.ex. the chat window instead of the browser window with the password dialog as the user intended. Of course that maybe just me and my usual sausage fingers :-) |
Fill form shortcuts are the only thing that depends on
class Keypress, which on Linux is dependent on X11. When the program is running in a Wayland session, then those shortcuts do not work, i.e. they are useless, but still a X11 client connection is created.This PR makes all code related to those short cuts optional and the user can disable them with a build configuration option. I.e. she can create an executable that will be a pure Wayland client in a Wayland session.
Fixes #32