build: manually copy libcrypto DLL to windeploy #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah yes, that's not going to work: |
Unfortunately windeployqt doesn't handle non-Qt DLLs. To avoid that the user has to install OpenSSL by hand, find the DLL on the GitHub runner system and copy it manually to the windeploy/bin directory.
stefanb2
force-pushed
the
topic-add-libcrypto-to-windows-installer
branch
from
6ec0390 to
7715a12
Compare
This removes the hard-coded libcrypte DLL name. - locate path to dumpbin.exe in Visual Studio installation - execute dumpbin on installed binary and filter libcrypto DLL name from output. This Powershell command will fail if no match is found. - replace the hard-coded libcrypto DLL name in the copy command
stefanb2
force-pushed
the
topic-add-libcrypto-to-windows-installer
branch
from
c8817e1 to
1c9e0fb
Compare
|
Figured out the Powershell mojo to extract the libcrypto DLL name from the installed binary. Should now work even when the Windows/Visual Studio installation on the GitHub runners changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately windeployqt doesn't handle non-Qt DLLs. To avoid that the user has to install OpenSSL by hand, find the DLL on the GitHub runner system and copy it manually to the windeploy/bin directory.