Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added require keys method to raise if not defined #354

Merged
merged 1 commit into from
Sep 23, 2018
Merged

Added require keys method to raise if not defined #354

merged 1 commit into from
Sep 23, 2018

Conversation

dmitry-ilyashevich
Copy link
Contributor

No description provided.

@cadwallion cadwallion self-assigned this Sep 16, 2018
cadwallion
cadwallion approved these changes Sep 23, 2018
View reviewed changes
Copy link
Collaborator

@cadwallion cadwallion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been running this through its paces locally and it seems to do well. Thank you for the contribution!

@cadwallion cadwallion merged commit 879af5e into bkeepers:master Sep 23, 2018
@serggl
Copy link

serggl commented Dec 19, 2018

@cadwallion any chance this could be published to rubygems? Now it seem weird because documentation explains require_keys usage, but if you download and try to use this gem, you'll get :

undefined method `require_keys' for Dotenv:Module (NoMethodError)

this is what many struggle with: #359

@timrogers
Copy link

Nice change 😍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cadwallion cadwallion cadwallion approved these changes

Assignees

@cadwallion cadwallion

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dmitry-ilyashevich @serggl @timrogers @cadwallion