Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow following whitespace #277

Merged
merged 1 commit into from Jan 19, 2017
Merged

Allow following whitespace #277

merged 1 commit into from Jan 19, 2017

Conversation

ghost
Copy link

@ghost ghost commented Jan 18, 2017 •
edited by ghost
Loading

Hi!

I encountered the following problem(underscore => space).

NOTIFY_SLACK_CHANNEL='#channel_name'__
=> "'"

I think that it is okay to allow spaces at the end of the line.

Thanks.

bkeepers
bkeepers approved these changes Jan 19, 2017
View reviewed changes
Copy link
Owner

@bkeepers bkeepers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good!

@bkeepers bkeepers merged commit 63854ce into bkeepers:master Jan 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bkeepers @takisawa