Fix for #207, Some escaped '$' characters are not unescaped #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I hope the changes fix the issue. |
|
Thanks for the pull request, @dhunnapotha! It looks like there are still a couple build failures. Would you mind fixing them up and pinging me when they're ready? Thanks! |
|
Sure. Checking them out. |
Removed that regex and put that code into ruby logic
|
@bkeepers The test case failures are fixed. Am assuming I dont need to take care of the rubocop gemspec offenses. Let me know if it is not the case. |
Those are fixed in master. Thanks for the PR! |
bkeepers
added a commit
that referenced
this pull request
Dec 2, 2015
…r_v2 Fix for #207, Some escaped '$' characters are not unescaped
|
Cool. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue was that the regex was not capturing $ which are not followed by alphanumericals. So, cases like "BAR$" and "$$" were not handled.
Made changes to take care of these.