Fixing Wayland cmake definitions and linkage #250
Conversation
mtytel
changed the title
|
So 'Linux' actually wasn't matching CMAKE_SYSTEM_NAME and removing the single quotes makes it match so it turned on WAYLAND by default in the build above. That exposed some missing definitions and library linkage so I've fixed that here. I also turned off wayland by default which is how it was behaving originally (because it never matched 'Linux') |
|
Disclaimer: not a maintainer.
I think wayland is supposed to be turned on by default: #234 |
|
There was a lot of push recently in the distro and DE space this year to ditch XOrg finally. I would prefer to keep Wayland as default as long as it's working. |
|
It actually wasn't enabled by default before, it just looked like it was. |
mtytel
force-pushed
the
master
branch
2 times, most recently
from
46ff81a
to
aa8d5cc
Compare
|
Alright squashed my changes. It looks like the bgfx.cmake's bgfx amalgamated build doesn't work with wayland enabled but it compiles on newer bgfx. So I could update the bgfx ref. |
|
I bumped bgfx version so the amalgamated build with wayland enabled works. CI is passing in my fork. |
|
@bwrsandman this is ready to pull in. |
In newer versions of cmake this line triggers a CMP0127 warning. Removing the quotes because they're not needed in older versions of cmake and doesn't trigger the warning in newer version of cmake.