Make Message Writable After It Is Initially Set #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
bjyoungblood
added a commit
that referenced
this pull request
Mar 8, 2016
Make Message Writable After It Is Initially Set
|
Published v2.1.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Hapi, if an ES6Error is thrown outside of the request/reply lifecycle, Boom will attempt to catch the uncaught error and return a badImplementation. During this process they rewrite the message property to have "Uncaught Error:" in front of it (https://github.com/hapijs/boom/blob/master/lib/index.js#L124)
ES6Error's message isn't writable after initially being said so this causes Boom to throw a TypeError, which will crash the application.
Making the message writable solves this fatal crash (tested on my local branch)