-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made project more accessible to contributions #39
Conversation
@bjorn3 if the direction these commits are going in aligns with the project, I'd like to submit a couple more to add a browser test harness, integration tests, et al. |
Thanks a lot! I've got a couple of points where I disagree with eslint, but overall this is great.
Sure |
I reverted the extracted functions and added a simple debug logger that is disabled by default. |
7622d22
to
5879c2e
Compare
@bjorn3 LMK if you need anything else for this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this. If you don't mind could you do
I can transfer that repo to you as it makes more sense here.
first and update the submodule url before I merge?
Started the repo transfer. LMK when you've accepted and I'll update the PR |
Accepted the repo move. |
@bjorn3 thanks. I updated the relevant commit |
Released in v0.2.16. |
Thank you for this project @bjorn3!
This PR looks like a lot but has mostly cosmetic changes and is broken down into three commits:
prettier
check
taskcheck
taskI can break this PR down into three separate PRs if necessary.