Fix concatenate tests. #18
Conversation
|
@lbdreyer could you cast you eye over these changes to make sure you're happy with them. If you are then I'll merge (since you don't have merge rights on my repo 😉), otherwise comment on issue points and we'll discuss |
| # Setting the cube.data clears the cube.dtype and cube.fill_value. | ||
| # We want to maintain the fill_value for testing purposes, even | ||
| # though we have lost the lazy data in order to pin down the array | ||
| # data order to overcome testing on different architectures. |
There was a problem hiding this comment.
Should we be putting this comment everywhere we have done
fill_value = cube.fill_value
cube.data = ...
cube.fill_value = fill_value
There was a problem hiding this comment.
I've tried to leave some clue's (for my future self) but to be honest if we have a step change in the "persisting fill_value across a data setter operation" then we can always find the usage of fill_value in the code base.
I just added a bit more of context for concatenate because it's testing is a bit weird and, at the time, I thought an exception to the norm.
| cube.data = ma.array(data, mask=mask, fill_value=fill_value) | ||
| cube.data = ma.array(data, mask=mask) | ||
| else: | ||
| # cube.data = np.copy(cube.data, order=order) |
There was a problem hiding this comment.
Do you know why these were commented out in the first place?
There was a problem hiding this comment.
It was changed by @pp-mo 3 years ago ... I don't see the need to keep them
|
👍 Happy with the changes 👍 |
Ping @lbdreyer