Keep cube's fill_value when resetting the cube's data in interpolation test #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Fyi @pp-mo |
lbdreyer
force-pushed
the
fix_fill_value
branch
from
505355c to
0772732
Compare
bjlittle
reviewed
Mar 14, 2017
lib/iris/tests/test_interpolation.py
Outdated
| # * scipy.interpolate.interp1d in 0.11.0 which is used in | ||
| # `Linear1dExtrapolator`. | ||
| cube_fill_val = cube.fill_value | ||
| print(cube._dtype, cube.dtype) |
Owner
There was a problem hiding this comment.
@lbdreyer Nuke the print ? ... and also those below ?
bjlittle
reviewed
Mar 14, 2017
lib/iris/tests/test_interpolation.py
Outdated
|
|
||
| self.assertCML(res, ('analysis', 'interpolation', 'linear', | ||
| 'real_circular_2dslice.cml'), checksum=False) | ||
| self.assertEqual('a', 'b') |
lbdreyer
force-pushed
the
fix_fill_value
branch
from
0772732 to
9b6636d
Compare
Author
|
@bjlittle I have removed all the unnecessary print statements now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a test for the deprecated function
iris.analysis._interpolate_private.lineara cube with lazy unmasked pp data is interpolated. After the interpolation the fill value is kept, but the test then passes the cube throughnormalise_orderwhich resets the cube's data thereby losing the fill value.I have not done anything to
dtypeas cube._dtype is always None throughout the test.