wip: added comments to tell svetlana what to update

lib/transaction/index.js

@@ -518,7 +518,8 @@ Transaction.prototype._markAsWeb = function _markAsWeb(rawURL) {
       }
     }
   }
-  this.baseSegment.markAsWeb()
+  // TODO: pass in tx
+  this.baseSegment.markAsWeb(this)
 }
 
 /**

lib/transaction/trace/segment.js

@@ -126,6 +126,7 @@ TraceSegment.prototype.isInCallbackState = function isInCallbackState() {
 }
 
 TraceSegment.prototype.probe = function probe(action) {
+  // move probing from transaction to a utility
   if (this.transaction.traceStacks) {
     this.transaction.probe(action, { segment: this.name })
   }
@@ -136,6 +137,7 @@ TraceSegment.prototype.probe = function probe(action) {
  * be named after the transaction it belongs to (which is only known by
  * the end).
  */
+// TODO: pass in tx
 TraceSegment.prototype.setNameFromTransaction = function setNameFromTransaction() {
   const transaction = this.transaction
 
@@ -154,6 +156,7 @@ TraceSegment.prototype.setNameFromTransaction = function setNameFromTransaction(
  * finally, marking the trace segment as being a web segment copies the
  * segment's parameters onto the transaction.
  */
+// TODO: pass in tx
 TraceSegment.prototype.markAsWeb = function markAsWeb() {
   const transaction = this.transaction
   this.setNameFromTransaction()

lib/transaction/tracer/index.js

@@ -76,7 +76,10 @@ function createSegment(name, recorder, _parent) {
     )
     return null
   }
+  // pass in agent config
+  // increment the transaction and agent counters here
   return parent.add(name, recorder)
+  // after segment is created add the recorder to the transaction
 }
 
 function addSegment(name, recorder, parent, full, task) {