Skip to content

Conversation

@abergs
Copy link
Member

@abergs abergs commented Sep 12, 2025

📔 Objective

I didn't know we had suport for dev containers and there were some setup steps that I stumbled upon and needed help to solve. I've documented what I think is the process, but I'm more than happy with edits.

Once this is merged we can also link to it from the contributing guidelines.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Sep 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.84%. Comparing base (ba57ca5) to head (c8b11c0).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6318   +/-   ##
=======================================
  Coverage   49.84%   49.84%           
=======================================
  Files        1824     1824           
  Lines       80899    80899           
  Branches     7178     7178           
=======================================
  Hits        40328    40328           
  Misses      39015    39015           
  Partials     1556     1556           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details871d28eb-7ade-4674-ab15-bd33cd74feaf

Great job! No new security vulnerabilities introduced in this pull request

Copy link
Contributor

@withinfocus withinfocus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bitwarden/contributing-docs#154 never got finished but we should get that done. The approach we've been using with documentation in repos is that the close-to-code content is about the component such as how it works and how an owning team would work on and maintain it; the contributing docs is for how to use it. This means that most of this content needs to show up in the other PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants