Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-16682] Provider setup tax information is not saved #5211

Merged
merged 2 commits into from
Jan 5, 2025
Merged

Conversation

jonashendrickx
Copy link
Member

@jonashendrickx jonashendrickx commented Jan 3, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-16682

📔 Objective

Provider setup would not save the tax id or show a localized error message.

📸 Screenshots

image

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@jonashendrickx jonashendrickx requested a review from a team as a code owner January 3, 2025 12:13
Copy link

codecov bot commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review.

Project coverage is 43.85%. Comparing base (840ff00) to head (4acc6db).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
.../Commercial.Core/Billing/ProviderBillingService.cs 94.73% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5211   +/-   ##
=======================================
  Coverage   43.84%   43.85%           
=======================================
  Files        1467     1467           
  Lines       67630    67643   +13     
  Branches     6112     6115    +3     
=======================================
+ Hits        29654    29666   +12     
  Misses      36683    36683           
- Partials     1293     1294    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Jan 3, 2025

Logo
Checkmarx One – Scan Summary & Details6383bae0-e6d6-46fd-affb-4eb3f7aecc40

New Issues

Severity Issue Source File / Package Checkmarx Insight
LOW Log_Forging /src/Api/AdminConsole/Controllers/ProvidersController.cs: 72 Attack Vector

@jonashendrickx jonashendrickx merged commit ff84628 into main Jan 5, 2025
52 of 53 checks passed
@jonashendrickx jonashendrickx deleted the PM-16682 branch January 5, 2025 10:14
@jonashendrickx jonashendrickx restored the PM-16682 branch January 13, 2025 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants