Auth/PM-3833 - Remove Deprecated Register and Prelogin endpoints from API #4206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ve prelogin and register endpoints.
…n and PostRegister from API to Identity.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4206 +/- ##
==========================================
- Coverage 40.68% 40.55% -0.14%
==========================================
Files 1239 1235 -4
Lines 59492 59328 -164
Branches 5434 5423 -11
==========================================
- Hits 24206 24058 -148
+ Misses 34160 34144 -16
Partials 1126 1126 ☔ View full report in Codecov by Sentry. |
…egister-and-prelogin-from-api # Conflicts: # src/Identity/Controllers/AccountsController.cs # test/Identity.IntegrationTest/Controllers/AccountsControllerTests.cs # test/Identity.Test/Controllers/AccountsControllerTests.cs
This comment was marked as off-topic.
This comment was marked as off-topic.
jlf0dev
approved these changes
Jun 19, 2024
JaredSnider-Bitwarden
deleted the
auth/pm-3833/remove-register-and-prelogin-from-api
branch
doy
added a commit
to doy/rbw
that referenced
this pull request
Jun 26, 2024
the prelogin endpoint on the base api is being removed soon, see bitwarden/server#4206
withinfocus
pushed a commit
that referenced
this pull request
Jul 9, 2024
… API (#4206) * PM-3833 - API - AccountsController.cs && AccountsController.cs - remove prelogin and register endpoints. * PM-3833 - Move Request and Response models that were used for Prelogin and PostRegister from API to Identity. * PM-3833 - FIX LINT * PM-3833 - Fix issues after merge conflict fixes. * PM-3833 - Another test fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-3833
Work this was based on: #3255 (had too many merge conflicts so it was just easier to redo the changes in a new branch).
📔 Objective
To clean up the deprecated Register & Prelogin endpoints from API. Updated tests and moved response & request models to Identity.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes