-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BRE-342 Implement retry mechanism with error handling to get secrets from KV #329
Conversation
No New Or Fixed Issues Found |
…esponses in getSecretValue to prevent failures and retry up to 3 times with a delay
…response and apiResult errors
…ive code into a helper function for cleaner retries
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR body is missing all the information. Can you please fill it out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was able to test with debug and finally get an error that retried successfully. This will work as a temporary fix until we can move on from using Azure Key Vaults.
🎟️ Tracking
BRE-342
📔 Objective
Fix
get-keyvault-secrets
action intermittent failures by implementing retry mechanism with error handling to get secrets from Azure Key Vault.📸 Screenshots
Known issues: https://github.com/bitwarden/server/actions/runs/11033476838/job/30644953330
In this execution we can clearly see that the retry mechanism was executed due to the execution time,
9 seconds
compare to the6 seconds
when the step failed (RETRY_DELAY = 3000):https://github.com/bitwarden/server/actions/runs/11167289676/job/31043388477
Multiple jobs were triggered:
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes