Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add atomic PR ID job - Python tool POC #212

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

joseph-flinn
Copy link
Contributor

@joseph-flinn joseph-flinn commented Nov 22, 2023

🎟️ Tracking

Testing idea of atomic and testable workflow jobs

🚧 Type of change

  • 🚀 New feature development
  • 🤖 Build/deploy pipeline (DevOps)

📔 Objective

Add an atomic job to pull the PR ID that is associated with a commit SHA built in Python with a full suite for testing (POC;: should be thrown out if we want to adopt something like this).

📋 Code changes

  • .github/jobs-py: new directory with script and supporting tests for those job scripts
  • .github/workflows/test_jobs_py.yml: CI pipeline to test changes to the python automation jobs

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@joseph-flinn joseph-flinn requested a review from a team as a code owner November 22, 2023 19:48
@joseph-flinn joseph-flinn marked this pull request as draft November 22, 2023 19:48
Copy link

sonarcloud bot commented Sep 4, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant