Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-18081] admins owners and canManageUsers permissions can see the modal #13302

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

BTreston
Copy link
Contributor

@BTreston BTreston commented Feb 6, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-18081

📔 Objective

Adds modal for admins and users with canManageUser permissions

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@BTreston BTreston requested a review from a team as a code owner February 6, 2025 22:14
@BTreston BTreston requested a review from jrmccannon February 6, 2025 22:14
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.10%. Comparing base (179ddc2) to head (a8f4a3c).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13302   +/-   ##
=======================================
  Coverage   35.10%   35.10%           
=======================================
  Files        3031     3031           
  Lines       92509    92509           
  Branches    16838    16838           
=======================================
  Hits        32476    32476           
  Misses      57579    57579           
  Partials     2454     2454           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Feb 6, 2025

Logo
Checkmarx One – Scan Summary & Details624aca39-827f-4f8f-9e9a-7bb2abc05044

Great job, no security vulnerabilities found in this Pull Request

@BTreston BTreston merged commit a42d530 into main Feb 7, 2025
46 of 47 checks passed
@BTreston BTreston deleted the ac/pm-18081-non-owners-cant-see-modal branch February 7, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants