[PM-17665] Move cryptofunction service to km

[quexten]

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-17665

📔 Objective

Moves cryptofunctionservice to KM ownership.

📸 Screenshots

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[codecov]

Codecov Report

Attention: Patch coverage is 25.80645% with 23 lines in your changes missing coverage. Please review.

Project coverage is 35.05%. Comparing base (59da991) to head (6bdc6dc).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
apps/browser/src/popup/services/services.module.ts	0.00%	2 Missing ⚠️
libs/angular/src/services/jslib-services.module.ts	0.00%	2 Missing ⚠️
apps/browser/src/auth/popup/login-v1.component.ts	0.00%	1 Missing ⚠️
.../auth/popup/login-via-auth-request-v1.component.ts	0.00%	1 Missing ⚠️
apps/browser/src/auth/popup/sso-v1.component.ts	0.00%	1 Missing ⚠️
apps/browser/src/background/main.background.ts	0.00%	1 Missing ⚠️
...c/app/services/renderer-crypto-function.service.ts	0.00%	1 Missing ⚠️
apps/desktop/src/app/services/services.module.ts	0.00%	1 Missing ⚠️
apps/desktop/src/auth/login/login-v1.component.ts	0.00%	1 Missing ⚠️
.../auth/login/login-via-auth-request-v1.component.ts	0.00%	1 Missing ⚠️
... and 11 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #13285      +/-   ##
==========================================
- Coverage   35.05%   35.05%   -0.01%     
==========================================
  Files        3036     3036              
  Lines       92720    92720              
  Branches    16888    16888              
==========================================
- Hits        32507    32500       -7     
- Misses      57750    57757       +7     
  Partials     2463     2463              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Checkmarx One – Scan Summary & Details – 6588bf7a-e306-4b94-a342-72087b18f04d

Great job, no security vulnerabilities found in this Pull Request

[mzieniukbw]

Please also add below to key-management

[jprusik]

Approved for Autofill concerns

[Patrick-Pimentel-Bitwarden]

Should this not be a relative import?

[quexten]

I double checked with @Thomas-Avery since you raised the same comment on the encrypt service PR. If something is within a package - in this case libs/common/, then we should use relative imports. In this case the import is in libs/common/src/auth/services/webauthn-login/webauthn-login-prf-key.service.ts, importing libs/common/src/key-management/crypto/abstractions/crypto-function-service.ts, so both are under the libs/common package and we should use a relative import.

If we were importing cross package (i.e in libs/common we would be importing something from libs/key-management/@bitwarden/key-management), then we would not use relative imports.

I don't know if this is just a key-management policy, or applies to all teams. Maybe @Thomas-Avery can chime in.

[Patrick-Pimentel-Bitwarden]

Thank you for the clarification and that all tracks. I apologize for not scrutinizing these imports further than a surface level observation.

[Patrick-Pimentel-Bitwarden]

👍 Changes look good, non blocking comment.

[shane-melton]

Vault changes look good to go!