Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-14419] At-risk passwords change password service #13279

Open
wants to merge 5 commits into
base: vault/pm-14421/at-risk-passwords-browser
Choose a base branch
from

Conversation

shane-melton
Copy link
Member

@shane-melton shane-melton commented Feb 6, 2025

🎟️ Tracking

PM-14419

📔 Objective

Introduce a service to attempt to determine the well-known change password URL for a given login item. Use that service on the At-risk Passwords page that allows users to directly navigate to the change password page for their items that have been determined to be at-risk.

📸 Screenshots

Screen.Recording.2025-02-05.at.4.32.41.PM.mov

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@shane-melton shane-melton requested a review from a team as a code owner February 6, 2025 00:34
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 77.27273% with 10 lines in your changes missing coverage. Please review.

Project coverage is 35.15%. Comparing base (e493ea8) to head (e0e7b32).

Files with missing lines Patch % Lines
...s/at-risk-passwords/at-risk-passwords.component.ts 41.66% 7 Missing ⚠️
.../services/default-change-login-password.service.ts 89.65% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@                             Coverage Diff                              @@
##           vault/pm-14421/at-risk-passwords-browser   #13279      +/-   ##
============================================================================
+ Coverage                                     35.14%   35.15%   +0.01%     
============================================================================
  Files                                          3035     3037       +2     
  Lines                                         92627    92667      +40     
  Branches                                      16844    16848       +4     
============================================================================
+ Hits                                          32551    32576      +25     
- Misses                                        57620    57634      +14     
- Partials                                       2456     2457       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Feb 6, 2025

Logo
Checkmarx One – Scan Summary & Details14e1a2a4-4a7d-42a4-8de2-43ab4dbc5ba3

Great job, no security vulnerabilities found in this Pull Request

@shane-melton shane-melton force-pushed the vault/pm-14419/change-password-url-service branch from 56a1e02 to 5b04637 Compare February 6, 2025 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant