Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-17670] Move KeyConnectorService to KM ownership #13277

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Thomas-Avery
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-17670

📔 Objective

The objective of this PR is to move the KeyConnectorService to KM ownership.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@Thomas-Avery Thomas-Avery self-assigned this Feb 5, 2025
Copy link
Contributor

github-actions bot commented Feb 5, 2025

Logo
Checkmarx One – Scan Summary & Details8b016993-be30-4d38-b3c1-e49e20b0a478

Fixed Issues (2)

Great job! The following issues were fixed in this Pull Request

Severity Issue Source File / Package
MEDIUM Client_Privacy_Violation /libs/vault/src/components/download-attachment/download-attachment.component.ts: 29
MEDIUM Client_Privacy_Violation /libs/vault/src/components/download-attachment/download-attachment.component.ts: 29

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 57.14286% with 6 lines in your changes missing coverage. Please review.

Project coverage is 35.10%. Comparing base (28d9202) to head (55d626d).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
libs/angular/src/services/jslib-services.module.ts 0.00% 2 Missing ⚠️
apps/browser/src/background/main.background.ts 0.00% 1 Missing ⚠️
apps/desktop/src/app/app.component.ts 0.00% 1 Missing ⚠️
apps/web/src/app/app.component.ts 0.00% 1 Missing ⚠️
...r/src/auth/components/remove-password.component.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13277      +/-   ##
==========================================
+ Coverage   35.05%   35.10%   +0.05%     
==========================================
  Files        3036     3031       -5     
  Lines       92723    92516     -207     
  Branches    16890    16838      -52     
==========================================
- Hits        32502    32481      -21     
+ Misses      57757    57581     -176     
+ Partials     2464     2454      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Thomas-Avery Thomas-Avery marked this pull request as ready for review February 6, 2025 21:30
@Thomas-Avery Thomas-Avery requested review from a team as code owners February 6, 2025 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants