Migrate Renovate config to JSON5 #13233
Open
+89
−85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixed Issues (80)Great job! The following issues were fixed in this Pull Request
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13233 +/- ##
=======================================
Coverage 35.04% 35.05%
=======================================
Files 3036 3036
Lines 92735 92735
Branches 16891 16891
=======================================
+ Hits 32501 32508 +7
+ Misses 57768 57761 -7
Partials 2466 2466 ☔ View full report in Codecov by Sentry. |
withinfocus
reviewed
Feb 5, 2025
|
I think I would personally lean towards leaving |
|
@justindbaur @withinfocus This is further proven by the fact that because prettier is not running on I also added a comment for demonstration. |
|
I applied bitwarden/server@a10ebd7 so we can see the server-side change (I run Prettier on file save in VS Code personally). Are we OK with this (on both sides)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-17932
📔 Objective
In order to support commenting, we would like to move our Renovate config to JSON5.
This required us to introduce
json5as a directnpmdependency as well, which I added to the list of owned dependencies for Platform in Renovate.PR #13234 depends on this one and will start to introduce comments for more complex configuration scenarios.
Note the corresponding server PR: bitwarden/server#5366.
Other repos can be migrated to JSON5 as needed, with a preference for those that have complex grouping that would benefit from explanatory comments.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes