fix: zh-TW registerLocaleData missing extra error #13210
+6
โ1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
๐๏ธ Tracking
#12933
#6821
#5220
๐ Objective
Fix zh-TW time format requires extra Day Periods.
I looked at angular/angular#54114 where they talked about Unable to find zh-Hant-TW, but bitwarden uses zh-Hant so it doesn't affect the usage.
what we encountered is the locale DatePipe error.
The default time format of CLDR zh-Hant is Bh uses Day Periods.
Angular places Day Periods in the extra folder.
Use translation, which may not be grammatically correct๐
๐ธ Screenshots
desktop
web
browser
โฐ Reminders before review
๐ฆฎ Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or โน๏ธ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or ๐ญ (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or โป๏ธ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes