Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: zh-TW registerLocaleData missing extra error #13210

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nick411077
Copy link

๐ŸŽŸ๏ธ Tracking

#12933
#6821
#5220

๐Ÿ“” Objective

Fix zh-TW time format requires extra Day Periods.

I looked at angular/angular#54114 where they talked about Unable to find zh-Hant-TW, but bitwarden uses zh-Hant so it doesn't affect the usage.

what we encountered is the locale DatePipe error.
The default time format of CLDR zh-Hant is Bh uses Day Periods.
Angular places Day Periods in the extra folder.

Use translation, which may not be grammatically correct๐Ÿ™‡

๐Ÿ“ธ Screenshots

desktop

ๆˆชๅœ– 2025-02-03 ๅ‡Œๆ™จ2 49 35

web

ๆˆชๅœ– 2025-02-03 ๅ‡Œๆ™จ2 46 55

browser


ๆˆชๅœ– 2025-02-03 ๅ‡Œๆ™จ2 41 11

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@nick411077 nick411077 requested a review from a team as a code owner February 2, 2025 19:07
@nick411077 nick411077 requested a review from coroiu February 2, 2025 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant