Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-17628] Move all files from libs/importer/spec into libs/importer/src #13202

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

djsmith85
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-17628

📔 Objective

This PR moves all files from libs/importer/spec into libs/importer/src in preparation to separate libs/importer into libs/importer-core and libs/importer-ui packages
Renamed test-data dir to spec-data dir

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@djsmith85 djsmith85 requested review from a team as code owners February 1, 2025 11:31
@djsmith85 djsmith85 requested a review from justindbaur February 1, 2025 11:31
Copy link
Contributor

github-actions bot commented Feb 1, 2025

Logo
Checkmarx One – Scan Summary & Details8f4dde5b-0274-4cad-ad45-cb86ddf484f4

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented Feb 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.55%. Comparing base (1d71212) to head (883b918).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13202      +/-   ##
==========================================
+ Coverage   35.48%   35.55%   +0.06%     
==========================================
  Files        3007     3100      +93     
  Lines       90899    90996      +97     
  Branches    16908    16908              
==========================================
+ Hits        32260    32354      +94     
- Misses      56137    56140       +3     
  Partials     2502     2502              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@djsmith85 djsmith85 enabled auto-merge (squash) February 1, 2025 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant