Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't limit password history to login types #13199

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

jaasen-livefront
Copy link
Collaborator

@jaasen-livefront jaasen-livefront commented Jan 31, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-16707

📔 Objective

This PR fixes an issue where the password history for hidden fields was not being displayed for Secure Notes, Cards, and Identities.

📸 Screenshots

Screen.Recording.2025-01-31.at.4.01.49.PM.mov

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@jaasen-livefront jaasen-livefront requested a review from a team as a code owner January 31, 2025 23:57
Copy link
Contributor

github-actions bot commented Feb 1, 2025

Logo
Checkmarx One – Scan Summary & Detailsecd63f49-c8d5-4e5a-ac01-7a8621471046

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented Feb 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.48%. Comparing base (ca53ecc) to head (7626b3d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13199   +/-   ##
=======================================
  Coverage   35.48%   35.48%           
=======================================
  Files        3007     3007           
  Lines       90899    90899           
  Branches    16908    16908           
=======================================
  Hits        32260    32260           
  Misses      56137    56137           
  Partials     2502     2502           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@djsmith85 djsmith85 linked an issue Feb 1, 2025 that may be closed by this pull request
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Password History" cannot be viewed for Secure Notes, Cards, or Identities
1 participant