Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-17717] Improve extension section header hover state #13192

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vleague2
Copy link
Contributor

@vleague2 vleague2 commented Jan 31, 2025

🎟️ Tracking

PM-17717

📔 Objective

This PR makes the following changes to the extension section header:

  • Arrow icon should be text-main color
  • Rounded edges on hover, and hide the bottom border on hover and focus when a section is closed
  • Hover background should be primary-100
  • Section header should have equal vertical spacing when hovered

📸 Screenshots

Screen.Recording.2025-01-31.at.4.23.16.PM.mov

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@vleague2 vleague2 requested a review from a team as a code owner January 31, 2025 21:27
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details6d81d8d0-b1a9-4a52-8d90-3ce134e21fa2

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.49%. Comparing base (ca53ecc) to head (122ece8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13192   +/-   ##
=======================================
  Coverage   35.48%   35.49%           
=======================================
  Files        3007     3007           
  Lines       90899    90899           
  Branches    16908    16908           
=======================================
+ Hits        32260    32267    +7     
+ Misses      56137    56130    -7     
  Partials     2502     2502           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@danielleflinn danielleflinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen recording matches my expectations. Thanks Vicki!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants